Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Upgrade to Rails 5.2. #143

Closed temochka closed 4 years ago

temochka commented 4 years ago

Summary

I upgraded test_track to Rails 5.2.

Other Information

All automated tests seem to pass locally and I was able to log in without a problem. Any others tests we should perform?

/domain @Betterment/test_track_core

nanda-prbot commented 4 years ago

@temochka needs to request platform review, or explicitly opt out, e.g.:

/no-platform

HOW TO: Request Reviewers

aburgel commented 4 years ago

<< domainlgtm

we should test out a deploy against a non-prod environment, and if that looks good then :shipit:

nanda-prbot commented 4 years ago

@temochka needs to request platform review, or explicitly opt out, e.g.:

/no-platform

HOW TO: Request Reviewers

smudge commented 4 years ago

/platform @smudge

nanda-prbot commented 4 years ago

Needs somebody from @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

smudge commented 4 years ago

platform LGTM!

nanda-prbot commented 4 years ago

@temochka merged without required approvals. (╯°□°)╯︵ ┻━┻ ɐʞɥɔoɯəʇ

nanda-prbot commented 4 years ago

Needs somebody from @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

temochka commented 4 years ago

nanda?

nanda-prbot commented 4 years ago

Needs somebody from @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

temochka commented 4 years ago

@smudge << platform

nanda-prbot commented 4 years ago

Approved! :heart_eyes_cat: :sun_with_face: :ok_hand: