Closed samandmoore closed 3 years ago
Needs somebody from @Betterment/test_track_core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
@samandmoore needs to incorporate feedback from @aburgel. Bump when done.
One comment on wording
bump!
i ended up having to sneak some rails 5.2 stuff in here because the app was not working properly locally without those changes. there's still some funkiness with auto-loading, but we can figure that out separately
Needs @aburgel to provide domain review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
bump @aburgel
i'm just trying to determine if we can remove some of the environments/ files
i'm just trying to determine if we can remove some of the environments/ files
determined! and deleted.
domainlgtm!
looks like travis is choking on the ruby 2.4 build. i'd say it's time to retire that version.
Summary
Since we added "remote kills" and "feature completions" to the TestTrack feature set, we have not updated the Admin UI to display them. This PR adds both of these features as tables on the split details screen.
feature gate with feature completion and remote kill![image](https://user-images.githubusercontent.com/407586/104054872-dccba580-51bb-11eb-849a-d4cbabeeb040.png)
feature gate with no completions![image](https://user-images.githubusercontent.com/407586/104054918-ef45df00-51bb-11eb-8657-07bc11afe867.png)
experiments don't use feature completions![image](https://user-images.githubusercontent.com/407586/104054963-fff65500-51bb-11eb-869c-a8a6b965b871.png)
experiment with no completions and no remote kills![image](https://user-images.githubusercontent.com/407586/104055006-0be21700-51bc-11eb-9e5d-21e6c0440620.png)
Other Information
I also upgraded to mini_racer because i couldn't run the app locally otherwise.
/domain @Betterment/test_track_core /no-platform