Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Add Feature Completions and Remote Kills to Split details screen #147

Closed samandmoore closed 3 years ago

samandmoore commented 3 years ago

Summary

Since we added "remote kills" and "feature completions" to the TestTrack feature set, we have not updated the Admin UI to display them. This PR adds both of these features as tables on the split details screen.

feature gate with feature completion and remote kill image

feature gate with no completions image

experiments don't use feature completions image

experiment with no completions and no remote kills image

Other Information

I also upgraded to mini_racer because i couldn't run the app locally otherwise.

/domain @Betterment/test_track_core /no-platform

nanda-prbot commented 3 years ago

Needs somebody from @Betterment/test_track_core to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

nanda-prbot commented 3 years ago

@samandmoore needs to incorporate feedback from @aburgel. Bump when done.

HOW TO: Resolve Feedback

jmileham commented 3 years ago

One comment on wording

samandmoore commented 3 years ago

bump!

i ended up having to sneak some rails 5.2 stuff in here because the app was not working properly locally without those changes. there's still some funkiness with auto-loading, but we can figure that out separately

nanda-prbot commented 3 years ago

Needs @aburgel to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

samandmoore commented 3 years ago

bump @aburgel

i'm just trying to determine if we can remove some of the environments/ files

samandmoore commented 3 years ago

i'm just trying to determine if we can remove some of the environments/ files

determined! and deleted.

aburgel commented 3 years ago

domainlgtm!

looks like travis is choking on the ruby 2.4 build. i'd say it's time to retire that version.