Closed samandmoore closed 3 years ago
Needs somebody from @Betterment/test_track_core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain TAFN
@samandmoore needs to incorporate feedback from @smudge. Bump when done.
bump!
Needs @smudge to provide domain review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
domain LGTM!
Summary
in #148 we discussed creating a v4 version of the /builds/:timestamp/split_registry endpoint that is used by the rails client and js client (transitively).
this PR adds that endpoint for future consumption. this is nice in that it allows all the clients to be consuming the same version of the split registry schema (v4) whenever they're updated.
this PR also introduces the
experience_sampling_weight
to the v4 endpoints.NOTE: i moved the
experience_sampling_weight
loading behavior from theSplitRegistry
model to theRails.configuration
inapplication.rb
. This felt like a better way to share the behavior between theSplitRegistry
-based and the non-SplitRegistry
-based ways of getting at the list of applicable splits for a client (via app+version+timestamp or via build timestamp) cc @jmileham @aburgel the main result of this move is that the tests covering the tiny bit of behavior for validating the experience sampling weight are gone/domain @Betterment/test_track_core /no-platform