Closed samandmoore closed 3 years ago
Needs somebody from @Betterment/test_track_core to claim domain review
Use the shovel operator to claim, e.g.:
@myname << domain && platform
<< domain << platform tafn
@samandmoore needs to incorporate feedback from @jmileham. Bump when done.
bump @jmileham thoughts?
Needs @jmileham to provide domain review Needs @jmileham to provide platform review
When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
TAFN
orDomainLGTM
If you're too busy to review, unclaim the PR, e.g.:
@myname >> domain
This looks awesome.
Domain lgtm platform lgtm!
Summary
TT client side log-ins are done with a combination of two API calls:
POST /v1/identifier
followed by aGET
to a v4 app version build path visitor configs endpoint. We'd like to replace this POST + GET chain with a single endpoint that performs the combined behavior of both endpoints.We'd like to remove the
GET /v4/apps/:app_id/versions/:version_id/builds/:timestamp/identifier_types/:identifier_type/identifiers/:value/visitor_config
endpoint. This endpoint is not used and never has been.The new endpoint will look like this:
POST /v4/apps/:app_id/versions/:version_id/builds/:timestamp/identifier
{ identifier_type: 'broker_dealer_user_id', value: '123', visitor_id: 'current client-side visitor id' }
Other Information
The v4 app version build path identifier visitor configs endpoint was recently added, but never used, so we feel good deleting it.
/domain @Betterment/test_track_core /no-platform