Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Add V4 Identifier POST endpoint, remove unused V4 GET endpoint #150

Closed samandmoore closed 3 years ago

samandmoore commented 3 years ago

Summary

The new endpoint will look like this:

POST /v4/apps/:app_id/versions/:version_id/builds/:timestamp/identifier { identifier_type: 'broker_dealer_user_id', value: '123', visitor_id: 'current client-side visitor id' }

Other Information

The v4 app version build path identifier visitor configs endpoint was recently added, but never used, so we feel good deleting it.

/domain @Betterment/test_track_core /no-platform

nanda-prbot commented 3 years ago

Needs somebody from @Betterment/test_track_core to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

jmileham commented 3 years ago

<< domain << platform tafn

nanda-prbot commented 3 years ago

@samandmoore needs to incorporate feedback from @jmileham. Bump when done.

HOW TO: Resolve Feedback

samandmoore commented 3 years ago

bump @jmileham thoughts?

nanda-prbot commented 3 years ago

Needs @jmileham to provide domain review Needs @jmileham to provide platform review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

HOW TO: Give Feedback

jmileham commented 3 years ago

This looks awesome.

Domain lgtm platform lgtm!