Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

If CI is set and CAPYBARA_DRIVER is not, use remote chrome #170

Closed smudge closed 2 years ago

smudge commented 2 years ago

Summary

A minor compatibility update to support default behavior on other build systems. We'll still use selenium_chrome_headless in GitHub CI, but will default to selenium_remote_chrome in other build systems.

/domain @Betterment/test_track_core @kelvin-acosta /no-platform

nanda-prbot commented 2 years ago

Needs somebody from @Betterment/test_track_core and @kelvin-acosta to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

kelvin-acosta commented 2 years ago

<< domainLGTM

nanda-prbot commented 2 years ago

Review by @kelvin-acosta isn't sufficient because they don't have write access. This PR requires domain review from a collaborator with write access to the repo.

kelvin-acosta commented 2 years ago

<< domainLGTM