search

Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

feat: upgrade Rails to v6.0.6.1 #182

Closed HipsterBrown closed 1 year ago

HipsterBrown commented 1 year ago

Summary

To support new feature development and replacing older, vendored dependencies, this PR upgrades Rails from 5.2.4 to 6.0.6.1, along with associated dependencies through bundle update. One of these upgrades includes betterlint, so most of the changes are automatic fixes to Rubocop rules.

Other Information

If there's anything else that's important and relevant to your pull request, mention that information here. This could include benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core

samandmoore commented 1 year ago

just wanted to check in here at a high-level... did you follow along with the upgrade instructions here when you went through this? https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-2-to-rails-6-0

with rails upgrades there's usually a bunch of small to medium gotchas that are captured in those guides. in this case, going from 5.2 to 6.0 there were a buncha things to consider.

HipsterBrown commented 1 year ago

@samandmoore I took a look at the general upgrade guide but looked closer at the 5.2 -> 6.0 guide you linked. Made some changes that still look good. I decided not to include webpacker in this upgrade given its deprecated status.

samandmoore commented 1 year ago

re: webpacker - makes sense. i think we skip right over it to whatever's next ... in another change down the line

HipsterBrown commented 1 year ago

@smudge @samandmoore I've upgraded betterlint to the latest release (v1.4.0) to resolve the FactoryBot SyntaxMethods rule changes. Thanks for your review!