search

Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Opt into some Rails 7 defaults #196

Closed argvniyx-enroute closed 1 year ago

argvniyx-enroute commented 1 year ago

Summary

I ran bundle exec rake app:update and picked sensible changes, like replacing single with double quotes. I also tried rearranging some code to reduce the diff produced by the app:update task, which might help in future updates.

Then, I opted into Rails 7 defaults, following https://docs.google.com/document/d/12xORkFvfQzPc3RC9A1HeDKdaom3cKr-hPSPqJBjU6XY. There are some defaults that need testing, so I'll leave them for a future PR.

Other Information

If there's anything else that's important and relevant to your pull request, mention that information here. This could include benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain

argvniyx-enroute commented 1 year ago

Had some time to put https://github.com/Betterment/test_track/pull/197 together. As with chronos, it seems only specs related to cookies broke, so we should be good. We can try to update to the defaults in a single PR or I can revert if we'd rather do it in two steps.