search

Betterment / test_track

Server app for the TestTrack multi-platform split-testing and feature-gating system
MIT License
119 stars 33 forks source link

Upgrade Devise to 4.4.3 #79

Closed coreyja closed 6 years ago

coreyja commented 6 years ago

Summary

Upgrade Devise to version 4.4.3

This is done to pave the way to Rails 5.3 which is supported by Devise 4.4.

Devise Changelog: https://github.com/plataformatec/devise/blob/master/CHANGELOG.md#443---2018-03-17 Devise Diff from old version: https://github.com/plataformatec/devise/compare/v4.3.0...v4.4.3

/domain @samandmoore @betterzega /platform @samandmoore @betterzega

nanda-prbot commented 6 years ago

Needs somebody from @samandmoore and @betterzega to claim domain review Needs somebody from @samandmoore and @betterzega to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

betterzega commented 6 years ago

<< platformlgtm

I'll leave domain to @samandmoore who also has merge powers

nanda-prbot commented 6 years ago

Needs somebody from @samandmoore and @betterzega to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

samandmoore commented 6 years ago

<<domainlgtm

Changelog looks straightforward and tests are passing.

nanda-prbot commented 6 years ago

Approved! :golf: :taco: :nut_and_bolt: