search

Beuth-Erdelt / DBMS-Benchmarker

DBMS-Benchmarker is a Python-based application-level blackbox benchmark tool for Database Management Systems (DBMS). It connects to a given list of DBMS (via JDBC) and runs a given list of parametrized and randomized (SQL) benchmark queries. Evaluations are available via a Python interface and on an interactive multi-dimensional dashboard.
GNU Affero General Public License v3.0
13 stars 3 forks source link

JOSS Review - General checks #97

Closed simon-lewis closed 2 years ago

simon-lewis commented 2 years ago

JOSS Review – General Checks by @simon-lewis

Summary: Completed. No issues to address or raised (subject to Contributing Guidelines on publication).

(1) Repository – confirmed – sources available. No obvious issues.

(2) License – visible and confirmed as AGPL-3.0 – OSI approved

(3) Contribution and authorship – contributors confirmed. 336 commits for Patrick. 1 for Jascha. 100K+ lines contributed overall. No obvious issues except for missing contributing guidelines under Github Community Standards.

(4) Scholarly effort – confirmed above. No citations evident but no DOI yet. Suggested benefits are real and the software is cite-able based on these General Checks (i.e. subject to review of Software Paper, Documentation and Functionality). Note close relationship with the referenced paper at https://doi.org/10.1007/978-3-030-84924-5_6

Based on https://github.com/openjournals/joss-reviews/issues/4628

perdelt commented 2 years ago

Hi @simon-lewis many thanks for your checks!

As a reply: Jascha contributed quite a lot on the evaluation side. His commits have been squash-merged from another repository (so it counts as 1 here). The paper https://doi.org/10.1007/978-3-030-84924-5_6 motivated the design decisions of the package and showed some results that have been gained using the package. Otherwise the content is disjoint. In particular terminology, internal logic and usage can only be found in the JOSS publication.