BeverCRM / PCF-EditableTable

This control allows the transformation of the default Dynamics 365 grid to an editable grid with add new line functionality.
https://marketplace.bevercrm.com
MIT License
17 stars 4 forks source link

Bugs for editable table #19

Closed emibanana closed 1 year ago

emibanana commented 1 year ago

Sometimes the pup up warning menu is hidden behind the grid, which makes it unusable. See attached video If a record has a restriction for deletion because it has related child relationship that set to restrict deletion, the editable table will not give an error message like the out-of-the-box control do, it will simply assume it’s deleted successfully, but when you refresh it, it will come back again.

Here are some bugs that I have found:

1, Sometimes the pup up warning menu is hidden behind the grid, which makes it unusable.

image003

2, If a record has a restriction for deletion because it has related child relationship that set to restrict deletion, the editable table will not give an error message like the out-of-the-box control do, it will simply assume it’s deleted successfully, but when you refresh it, it will come back again.

And here are some suggestions for improvements:

image001

If The horizontal slider can appear always as a top element rather than placed at the bottom of the row, it will improve the experience significantly, so that user wont scroll down to the bottom to use the horizontal slider, see below pictures

image002

If you can allow only double clicking a certain area to go into the form of that row, rather than anywhere, that would improve the usage as well, as currently it gets very easy to go into the form view. Some fields are set as read only field, such as powerfx calculated column, or ready only field set by the table; they are editable in the editable table control, but will give an error when you try to save them. See below warning (which also shows bug no.1). If you can lock read only field that would be awesome!

RubenAghajanyan commented 1 year ago

Hi @emibanana,

Thanks for the information.

Bug 1: Can you please share more information (or maybe a recorded video), under which conditions it happens? We need to be able to reproduce.

Bug 2: We will fix it and let you know.

Improvements: Thanks for the suggestions. We will consider them with the new version and let you know.

emibanana commented 1 year ago

Hi @RubenAghajanyan

See below video, this was recorded on version 1.0, about few weeks ago.

https://github.com/BeverCRM/PCF-EditableTable/assets/120373920/8a1c67d7-53e8-4ecd-810f-1a8459148248

https://github.com/BeverCRM/PCF-EditableTable/assets/120373920/d39e2431-b585-48fb-a37a-5bb037a252a6

emibanana commented 1 year ago

Hi @emibanana,

Thanks for the information.

Bug 1: Can you please share more information (or maybe a recorded video), under which conditions it happens? We need to be able to reproduce.

Bug 2: We will fix it and let you know.

Improvements: Thanks for the suggestions. We will consider them with the new version and let you know.

Hi, would there be any ETA for this fix? I really love this control! :D

RubenAghajanyan commented 1 year ago

Hi @emibanana,

We are planning the first fix_release in the mid of July, which will include your bug fixes and some others.

RubenAghajanyan commented 1 year ago

@emibanana,

Regarding your 1st enhancement. Instead of scrolling down (to find a horizontal scroll), you can just select one row at the top and use keyboards left-arrow or right-arrow. See the video below.

editableTable

We're checking other bugs & enhancements. Will keep you updated.

emibanana commented 1 year ago

@emibanana,

Regarding your 1st enhancement. Instead of scrolling down (to find a horizontal scroll), you can just select one row at the top and use keyboards left-arrow or right-arrow. See the video below.

editableTable

We're checking other bugs & enhancements. Will keep you updated.

Yes you are right I just learnt that after I submitted, this was a out of box grid behaviour too. Also the out of box power Apps grid view also allows you to specify the total number of rows to show, which essentially defines the total height of the grid control. If I set it to 10-15, and allow auto adjustment based on available space, it will achieve what I want. I believe your pcf control can do that as well, either already implemented or not yet, I haven't tested it

RubenAghajanyan commented 1 year ago

yes, PCF will do the same. You can adjust row count, similar as in the standard Dynamics 365 grid.

emibanana commented 1 year ago

Yes thanks! Sorry just want to add more, not just arrow keys can let you scroll let or right, you can press shift and mouse scroll wheel to scroll left or right, which is the best method I believe as you barely need to move your hand. This is the default behaviour of dynamic grid control, hope your ones does that too ^_^

HasmikMn commented 1 year ago

Hello @emibanana,

We are happy to inform you that the new version of Editable Table is now available! Here are the details regarding the fixes and enhancements implemented from comments:

  1. Sometimes the pup up warning menu is hidden behind the grid, which makes it unusable. This issue is fixed now.

  2. If a record has a restriction for deletion because it has related child relationship that set to restrict deletion, the editable table will not give an error message like the out-of-the-box control do, it will simply assume it’s deleted successfully, but when you refresh it, it will come back again. The issue is fixed. If there is any restriction for deletion, you will receive an error popup, and the records will remain in the table without the need to refresh.

  3. If The horizontal slider can appear always as a top element rather than placed at the bottom of the row, it will improve the experience significantly, so that user wont scroll down to the bottom to use the horizontal slider, see below pictures This enhancement is now available. The horizontal slider will always be visible as a top element. Additionally, the header where the buttons are located, will also be visible as a top element, so that the user doesn't have to scroll up to save the changes.

  4. Some fields are set as read only field, such as powerfx calculated column, or ready only field set by the table; they are editable in the editable table control, but will give an error when you try to save them. Calculated and rollup fields are read only now.

The rest of the enhancements that haven't been addressed in this comment, will be considered in the upcoming versions.

Please confirm that the changes are fixed for you so we can close the issue. We appreciate your input and contribution on the development of this control!

RubenAghajanyan commented 1 year ago

@emibanana

The following issues are fixed.

  1. Sometimes the pop-up warning menu is hidden behind the grid, which makes it unusable. This issue is fixed now.

  2. If a record has a restriction for deletion because it has a related child relationship that is set to restrict deletion, the editable table will not give an error message like the out-of-the-box control does, it will simply assume it’s deleted successfully, but when you refresh it, it will come back again. The issue is fixed. If there is any restriction for deletion, you will receive an error popup, and the records will remain in the table without the need to refresh.

  3. If The horizontal slider can appear always as a top element rather than placed at the bottom of the row, it will improve the experience significantly, so that the user won't scroll down to the bottom to use the horizontal slider, see below pictures This enhancement is now available. The horizontal slider will always be visible as a top element. Additionally, the header where the buttons are located, will also be visible as a top element, so that the user doesn't have to scroll up to save the changes.

  4. Some fields are set as read-only, such as powerfx calculated column, or ready-only field set by the table; they are editable in the editable table control but will give an error when you try to save them. Calculated and rollup fields are read only now.

If you can allow only double-clicking a certain area to go into the form of that row, rather than anywhere - this one is not planned yet to be implemented, but we will consider it in future releases.

Closing this bug. If you'll have further issues please open a new bug.