search

Bevy-Rust-GPU / bevy-pbr-rust

rust-gpu port of bevy-pbr
Apache License 2.0
6 stars 1 forks source link

Incorrect value in sign determinant? #5

Closed davidm494 closed 1 year ago

davidm494 commented 1 year ago

This looks like a typo or copy/paste error, the "2.0" should probably be a "0.0". Or just remove the "* 2.0 - 1.0" and just return 1.0 and -1.0

https://github.com/Bevy-Rust-GPU/bevy-pbr-rust/blob/a0aba6242291877a5ed2a22e1f241f63947647d3/src/mesh/mod.rs#L55

Shfty commented 1 year ago

Good catch, thanks - fixed in 9e7a0b0, and I've pushed the v0.1.1 tag accordingly.