Bewelge / MIDIano

:musical_note: A JavaScript MIDI-Player/ Piano-learning webapp
https://midiano.com
118 stars 22 forks source link

piano line is displayed despite defaultSettings #14

Closed Neonunux closed 1 year ago

Neonunux commented 1 year ago

if piano line settings isn't checked, piano line is displayed.

to fix this, in js/Rendering/ThreeJs/ThreeJsPianoLine.js:

    if (getSetting('pianoLineEnabled')) {
      const material = new THREE.ShaderMaterial({
        uniforms: this.uniforms,
        transparent: true,
        opacity: 1,
        vertexShader: document.getElementById('simpleVertex').textContent,
        fragmentShader: document.getElementById('fragmentShaderPianoLine2')
          .textContent,
      })
Bewelge commented 1 year ago

Fixed