search

Bewelge / MIDIano

:musical_note: A JavaScript MIDI-Player/ Piano-learning webapp
https://midiano.com
125 stars 25 forks source link

bug with scroll laptop touchpad #18

Closed Neonunux closed 1 year ago

Neonunux commented 1 year ago

laptop touchpad sends a lot of event, overwhelming HandleScroll() in Player

Animation

fixed by l.238 in Player.js

this.scrollOffset = newScrollOffset

should be checked by

if (!Number.isNaN(newScrollOffset)) { this.scrollOffset = newScrollOffset }
Bewelge commented 1 year ago

How can I reproduce this?

Neonunux commented 1 year ago

on a laptop, you scroll right/left on laptop&touchpad

Bewelge commented 1 year ago

fixed