search

Bewelge / MIDIano

:musical_note: A JavaScript MIDI-Player/ Piano-learning webapp
https://midiano.com
118 stars 22 forks source link

Loop mode offset & input #41

Closed KieranGreenwood closed 7 months ago

KieranGreenwood commented 8 months ago

These two are pretty minor.

One thing that keeps catching me out. The loop start/end measures are offset by 1, If i choose start at 20, it starts from 21 etc...(zero-indexed array?) It would be nice if the numbers matched the visuals.

I feel like it would be easier if there was the option to type measure numbers in instead of just a range slider.

Bewelge commented 8 months ago

I agree with both. Will get on it

Bewelge commented 7 months ago

Added number inputs to all sliders and changed the indexing of the loops. Start: 1, End:1 will now loop Measure 1. Start: 1, End: 2 will loop the first two measures etc.