BeyondMafia / BeyondMafia-Integration

BeyondMafia Integration with EpicMafia.org
Other
14 stars 38 forks source link

Deaths need to be readdressed #908

Closed ghost closed 1 year ago

ghost commented 1 year ago

Since the graveyard change makes games expect a completely different history format (history[state].dead vs history[state].deaths), there are a few options:

  1. Old histories should be converted
  2. History processing should account for dead
  3. New History change should just be referred to "dead" as before, with front end checking if it's an object
  4. Move death time to a "deathTime" history, with front end checking if it exists

Personally I like the first option most since 2 and 3 rely on workarounds for keeping legacy, and 4 is bloating in the form of adding an entire second death-related property to a state history.

ghost commented 1 year ago

Old histories were updated to include a death property with the dead status and a null time. New histories will no longer have a dead property.