search

Bforartists / Manual

The Bforartists Manual
17 stars 4 forks source link

Properties Editor - Modifier Stack - Pin to Last needs updating #630

Closed Draise14 closed 3 months ago

Draise14 commented 3 months ago

image

Now there is a pin icon, thank goodness. It is also called "Pin to last".

Details SHA-1: 7ee189416c0d48e727ea186b4c58e2fd54fcf894 * UI: Show modifier pinning with icon, adjust name User feedback has been that the pinned modifier looks broken because there is no feedback in the UI showing that it's pinned (related to the recently reported #121620). It's also inconvenient to disable the pinning if it's required to move the modifier up (before another modifier that controls normals for example). Now the "Pin" icon is displayed here, and clicking on it turns off the pinning. Also, change the property name from "Stick to Last" to "Pin to Last". "Stick" is a weird word in the UI, it sounds uncommon and strangely physical. "Pin" is more associated with this concept. --- ![Screenshot from 2024-05-29 11-41-06](/attachments/4581d362-e2fb-4edf-83dd-7f1e1b71ec4d) Pull Request: https://projects.blender.org/blender/blender/pulls/122444
ReinerBforartists commented 3 months ago

Do we have a double now here? I can see a pin icon in the header and in the menu ...

I know i am pedantic, but what exactly is the task with "updating" ? What is the job here?

Draise14 commented 3 months ago

Right now it's NOT a double.

Check box to pin and unpin in the sub-menu. The pin icon only unpins, it is a visual indicator. There is no way to pin from the top-level.

Task

If documentation exists, update with this info.

Come to think of this, this pinning should be exposed to the top level right?

ReinerBforartists commented 3 months ago

So two pins? O_O

Draise14 commented 3 months ago

Yeah, I'll make a task to make it... one pin system. And top level.

ReinerBforartists commented 3 months ago

Thanks :)

Just realized that this is the manual tracker, i thought this is in the regular tracker. Sorry buddy.

But in fact, we don't do checkboxes in menus. So there is a task hiding here, and not just updating the manual.

Draise14 commented 3 months ago

Task created. https://github.com/Bforartists/Bforartists/issues/4338

Draise14 commented 3 months ago

https://github.com/Bforartists/Manual/assets/35357409/99463ad9-dbdc-4a44-a511-bd815832b6ac

Will document it now.