Fix URL to be much more consistent between bgee versions! - Githubissues

BgeeDB / bgee_apps

Source code of the Java Bgee applications

https://www.bgee.org/

Creative Commons Zero v1.0 Universal

2 stars 1 forks source link

Fix URL to be much more consistent between bgee versions! #154

Open fbastian opened 4 years ago

fbastian commented 4 years ago

In GitLab by @smoretti on May 8, 2017, 15:17

Need to be more consistent for URL to not mix links between bgee versions!

Bgee http links come from:

bgee.properties file org.bgee.webapp.bgeeRootDirectory = http://bgee.org/ variable. SHOULD BE http://bgee.org/bgeeX/
dataSource table baseUrl = http://bgee.org/. SHOULD BE http://bgee.org/bgeeX/

Bgee FTP links come from:

bgee.properties file org.bgee.webapp.ftpRootDirectory=ftp://ftp.bgee.org/current/ variable. SHOULD BE ftp://ftp.bgee.org/bgee_vX/ WITH bgee_vX a symlink to bgee_vX_Y
bgee.properties file org.bgee.webapp.download.......... variables. SHOULD USE org.bgee.webapp.ftpRootDirectory variable!!!!

Also add version in web.xml of the WAR!

NO global ${filter.org.bgee.webapp.XXX} variable(s) for FTP URLs

fbastian commented 4 years ago

In GitLab by @smoretti on May 29, 2017, 16:00

Need to be done with @vrechdelaval

fbastian commented 4 years ago

In GitLab by @smoretti on Sep 20, 2017, 16:13

Fixed for bgee URL in dataSource table

fbastian commented 4 years ago

In GitLab by @smoretti on Sep 20, 2017, 16:50

See https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html for filtering/substitution of properties by maven

fbastian commented 4 years ago

In GitLab by @smoretti on Oct 2, 2017, 11:47

Try with settings_prod.xml file to build a war now!

fbastian commented 4 years ago

In GitLab by @fbastian on Feb 6, 2018, 10:27

I think we can close this issue following the solution adopted for setting parameters @smoretti (addition of a README.md file in the webapp and of a maven setting example file).

fbastian commented 4 years ago

In GitLab by @smoretti on Feb 20, 2018, 14:31

Still this one should be fixed to help visualizing bgee war version in tomcat manager:

Also add version in web.xml of the WAR! (in \<display-name> tag)

fbastian commented 4 years ago

In GitLab by @fbastian on Feb 20, 2018, 20:24

I personally disagree with the display-name modification: I think it's boring to see the version in my browser window title.

fbastian commented 4 years ago

In GitLab by @fbastian on Feb 20, 2018, 20:57

Hmm, the display-name is not displayed in the browser actually? :x I was sure to have seen a change in web.xml impacting the window title :/ But it doesn't seem so.

fbastian commented 4 years ago

In GitLab by @smoretti on Feb 21, 2018, 09:28

It looks to be only used in the tomcat manager http://bioinfo.unil.ch/manager/html