Fix/factorisation of gene call retrieval and sorting #191

Closed fbastian closed 4 years ago

In GitLab by @fbastian on Jun 11, 2018, 17:52

Bug of the sorting of expression calls difficult to reproduce, affecting intermittently for instance this page: https://bgee.org/?page=gene&gene_id=FBgn0005596

Comparison method violates its general contract!

We need to fix this bug before refactoring the code retrieving and sorting expression calls for a gene. We need this refactoring for using it for:

the gene page
the uniprot XRef generation

Strategy:

@jwollbrett tries to identify exactly what causes the bug. We suspect it is the RankComparator that inconsistently orders some calls of same ranks. Bug difficult to reproduce because it depends on which calls the sort algorithm tries to compare.
Once the bug is fixed, @jwollbrett refactor the code for call retrieval and sorting in GeneService or CallService (to discuss)

In GitLab by @jwollbrett on Jun 18, 2018, 09:41

mentioned in commit d59dbcab5c3b40df33cfcaf2148cd8165944fd7e

In GitLab by @jwollbrett on Jul 24, 2018, 16:01

Bug has been fixed by @fbastian.

Two unit tests have been developed to be sure that the problem is solved. The corresponding hotfix branch has been merged into master and develop.

Code for call retrieval has been refactored in CallService and will be merged to develop by @vrech (see #191)

In GitLab by @jwollbrett on Jul 24, 2018, 16:02

closed

BgeeDB / bgee_apps

Fix/factorisation of gene call retrieval and sorting #191