BgeeDB / bgee_apps

Source code of the Java Bgee applications
https://bgee.org/
Creative Commons Zero v1.0 Universal
2 stars 1 forks source link

Do not use p-value as a parameter of TopAnat analysis #196

Open fbastian opened 4 years ago

fbastian commented 4 years ago

In GitLab by @jwollbrett on Sep 3, 2018, 09:34

p-value is currently used as a parameter of a TopAnat analysis. It means that it is used to generate the unique key of an analysis.

If a user want to run the same analysis with a different p-value, TopAnat analysis has to be run again (which is time consuming).

In the code the p-value is used to filter the results after running topGO. It could be a better idea to remove the p-value from both the generation of the unique key of an analysis and from filter step of the code. The p-value could be used only to filter data shown in the website.

Then, rerunning a TopAnat analysis with a different p-value will be extremely fast.

fbastian commented 4 years ago

In GitLab by @jwollbrett on Sep 3, 2018, 09:35

changed the description