BhallaLab / moose-core

C++ basecode and python scripting interface
https://moose.ncbs.res.in
GNU General Public License v3.0
15 stars 28 forks source link

Update needed for pybind11 #463

Closed subhacom closed 8 months ago

subhacom commented 1 year ago

On mac with Anaconda, Python 3.10.6, attempt to build moose results in compilation error:

... cast.h:446:36: error: member access into incomplete type 'PyFrameObject' (aka '_frame')
                "  " + handle(frame->f_code->co_filename).cast<std::string>() +
                                   ^
/opt/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/include/python3.11/pytypedefs.h:22:16: note: forward declaration of '_frame'
typedef struct _frame PyFrameObject;
               ^

This is a known issue that has been resolved in newer versions of PyBind11 (https://github.com/pybind/pybind11/discussions/4333?sort=top)

Copying the latest includes from pybind11 into moose-core/external/pybind11/include/pybind11 solves this issue.

hrani commented 8 months ago

Does this still exist? with the latest update hope this is resolved

subhacom commented 8 months ago

This should be resolved now.

On Sat, 9 Mar, 2024, 00:37 HarshaRani, @.***> wrote:

Does this still exist? with the latest update hope this is resolved

— Reply to this email directly, view it on GitHub https://github.com/BhallaLab/moose-core/issues/463#issuecomment-1986253087, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDFHX64QWOE5MSB5EKX4DYXIEANAVCNFSM6AAAAAAZKGBKXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGI2TGMBYG4 . You are receiving this because you authored the thread.Message ID: @.***>

hrani commented 8 months ago

Resolved in commit 8b37d2d691dfa