search

BhanwarSingh / sales-tax-calculator

0 stars 0 forks source link

Extract out business logic #1

Open vimalvnair opened 2 years ago

vimalvnair commented 2 years ago

Can you please extract the business logic from the Helper and move it to the models?

Also, make sure the variable and method names are descriptive. For example, what isarr here?: https://github.com/BhanwarSingh/sales-tax-calculator/blob/master/app/helpers/application_helper.rb#L4

BhanwarSingh commented 2 years ago

Hi @vimalvnair I have updated the code base as per your suggestion and extract the business logic from the helper and move it to the model.