Open BhavyaCodes opened 3 years ago
I'm gonna look at it!
it's fun adding pokemon ^^
Why add Pokemon manually, when you can actually use the provided API to get all the data you want using fetch
?
fetch(`https://pokeapi.co/api/v2/pokemon/${pokemonName}`)
.then(response => response.json())
.then(data => {
// use pokemon data to display it
});
Why add Pokemon manually, when you can actually use the provided API to get all the data you want using
fetch
?fetch(`https://pokeapi.co/api/v2/pokemon/${pokemonName}`) .then(response => response.json()) .then(data => { // use pokemon data to display it });
This is a great way to do things
hey, thanks for the suggestions but this project is mainly focused at beginners so they may get some practice with contributing to open source. I have already made a similar app that uses fetch, you can check it here https://pokemon-alpha.vercel.app/
@Juggernaut9 I added 40 Pokemon please merge it :)
I m gonna try this. Seems fun
@Juggernaut9 Can I work on and contribute to this?
@Juggernaut9 already added some if you want to merge. #46
@Juggernaut9 can I contribute to this?
yes you can @krishnasreekoganti
I raised a PR for new Pokemon @Juggernaut9 can you please review
@Juggernaut9 please accept my PRs for hacktoberfest https://github.com/Juggernaut9/pokemon/pull/67 https://github.com/Juggernaut9/pokemon/pull/68 https://github.com/Juggernaut9/pokemon/pull/69 https://github.com/Juggernaut9/pokemon/pull/70
Please accept my PRs for Hacktoberfest...!!
Hey @BhavyaCodes!!
I added 5 Pokémon for Hacktoberfest, but Vercel build failed. I can't see what's wrong with it, please tell me if anything needs fixing 😄!
PR: #74
Go to pokeapi website, Right below the Try It now heading you will find an api endpoint that you can try. replace ditto with your favorite pokemon, then edit /src/pokemon.json file. Add an object with the pokemon details in the array, be sure to get the id from pokeapi, you may use any imageurl, formatting should be exactly like the 2 original examples on top.
EDIT: please do not add more than 5 pokemon within a pull request! Current pull requests with upto 50 pokemon will be merged but more than that I'm sorry, I can't merge that, we don't have any system for pagination yet, also the data is saved in just a json file. It won't be efficient to import 1000 pokemon from json then sort them and render them on the DOM. This will also affect the search bar performance a lot