search

BhavyaCodes / pokemon

https://pokemon-hacktoberfest.vercel.app
15 stars 40 forks source link

added a React Router for Navigation #30

Closed rashidmakki closed 3 years ago

rashidmakki commented 3 years ago

added Route for Navigation to different pages and created a folder to separate different pages.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/juggernaut9/pokemon-hacktoberfest/k8eeiy5k3
✅ Preview: https://pokemon-hacktoberf-git-bf57f459a8bd333536929f2b3e78cedc3-96f3e7.juggernaut9.vercel.app

[Deployment for bbff280 failed]

BhavyaCodes commented 3 years ago

hey @rashidmakki someone else is already working on integrating react-router-dom and pagination. So I will keep this open for now

BhavyaCodes commented 3 years ago

Please fix the conflicts and also describe what exactly react-router-dom does here as there are no other pages at the moment

rashidmakki commented 3 years ago

So we can use Router at the Card Component. Whenever the user clicks on the card it will navigate to different pages (that means on the particular pokemon page where all the details of pokemon will be enlisted). From my point of view it can be achieve using Router and Higher Order Component. What is your view?