Closed DjDeveloperr closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/juggernaut9/pokemon-hacktoberfest/51z1bmbpl
✅ Preview: https://pokemon-hacktoberfest-git-fork-djdeveloperr-patch-1.juggernaut9.vercel.app
We can't handle so many pokemon, sorry. Please read https://github.com/Juggernaut9/pokemon/issues/1
Alright. But what about pagination? That can be done pretty easily. Haven't looked much into the code though. And there's no other efficient way to store Pokémon data in my opinion, JSON has been working good for me since ages. We can decrease load on client side by turning it into an API which is paginated. And thanks for that label :3
This PR contains complete Pokémon data for this project. And yes, its compatible with a small change(s). Things to note:
I believe the sprite URLs can be improved by not putting the image links in the data file. Just a simple template literal / string join. I haven't looked into code much, so I kept it like that. New properties can be used to make it more better, like adding page for every mon! And of course, rendered dynamically.
EDIT: there was a typo in script, URLs are broken. Fixed