Getting better Sprites - Githubissues

BhavyaCodes / pokemon

https://pokemon-hacktoberfest.vercel.app

15 stars 40 forks source link

Getting better Sprites #47

Open souranild opened 3 years ago

souranild commented 3 years ago

https://pokemondb.net/sprites this site has way better sprites and even gifs.

I can do a pr changing every pokemon sprites if needed. thoughts?

BhavyaCodes commented 3 years ago

Hey, this sounds like a lot of manual work, in the future we're gonna incorporate poke Api to fetch all pokemon, I don't think it would be worth it 🤔

souranild commented 3 years ago

yes @Juggernaut9 i get it. this site i tagged above is also automate-able.

for example if we want a gif of ivysur, we include https://img.pokemondb.net/sprites/black-white/anim/normal/ivysaur.gif so for getting any other pokemon's gif, we do https://img.pokemondb.net/sprites/black-white/anim/normal/{pokemon-name}.gif

DjDeveloperr commented 3 years ago

Hey, this sounds like a lot of manual work, in the future we're gonna incorporate poke Api to fetch all pokemon, I don't think it would be worth it 🤔

Better would be to generate image URL from Dex ID / Pokemon Name, storing them in the data file isn't an efficient way. I agree to above message. https://play.pokemonshowdown.com/sprites might be helpful.