search

BhavyaCodes / pokemon

https://pokemon-hacktoberfest.vercel.app
15 stars 40 forks source link

Remove Search Button #58

Open monddelmundo opened 3 years ago

monddelmundo commented 3 years ago

Hi, I will be removing the Search button.

ayushpattnaik commented 3 years ago

close the issue

monddelmundo commented 3 years ago

Hi @ayushpattnaik ,

This was discussed here. Can you let me know why you want this to be closed?

Thanks!

ayushpattnaik commented 3 years ago

hi @monddelmundo I mean the functionality is already added to the search button right? why to remove then?

monddelmundo commented 3 years ago

Hi @ayushpattnaik , @Juggernaut9 said it is no longer needed since the search bar is working. He confirmed that we should just delete it instead here. Thanks!

ayushpattnaik commented 3 years ago

Okay great!!

BlckShadow commented 3 years ago

Is this still open?

monddelmundo commented 3 years ago

Yes @BlckShadow . Waiting for PR #59 to be reviewed and merged.

BlckShadow commented 3 years ago

Ok I was just wondering since I'm a beginner and I want to take a react app since I'm new to react and I want to challenge my for final PR

BlckShadow commented 3 years ago

@monddelmundo Another q: Is only the button to remove and not the search field Correct? Would that make the search field useless?

monddelmundo commented 3 years ago

Hi @BlckShadow , No, the search field is functional even without the button. You can try it here: https://pokemon-hacktoberf-git-a2b908049849d42f333e10ed678078cb8-daada4.juggernaut9.vercel.app

You can look for the other issues posted for this project and try to solve those, like beautifying the site (#5 ).

BlckShadow commented 3 years ago

@monddelmundo Ah ok that's awesome

BlckShadow commented 3 years ago

Ok I would love to take this on for my final PR for Digital Ocean Hacktober for my final PR

BlckShadow commented 3 years ago

Ok, I also submit one for PR for this issue; thanks again for the attempt and learning experience with this hack fest

BlckShadow commented 3 years ago

@ayushpattnaik Hi I submitted a puller request for this issue but it still pending so I'm not sure what to do

ayushpattnaik commented 3 years ago

@ayushpattnaik Hi I submitted a puller request for this issue but it still pending so I'm not sure what to do

I guess the repo is inactive