search

Bhavyajain21 / Netflix-GPT

0 stars 2 forks source link

Login/Signup Form Input Validations using Formik #1

Open Bhavyajain21 opened 4 months ago

Bhavyajain21 commented 4 months ago

Implement validations on email, password and name field on signup/login form.

mademoiselle-chantal commented 4 months ago

Hello @Bhavyajain21. I want to take on this issue.

Bhavyajain21 commented 4 months ago

Go ahead, assigning this to you @mademoiselle-chantal

mademoiselle-chantal commented 4 months ago

Thanks! Am I allowed to pick out any form validation library of my choice, or are you the one who can suggest it?

Bhavyajain21 commented 4 months ago

Formik is one I would suggest. Feel free to use any of your choice

mademoiselle-chantal commented 4 months ago

Hello @Bhavyajain21. You were trying to add some code to validate that login form and you commented out that code. Is it still necessary or l can remove it and add mine which is going to use Formik?

Bhavyajain21 commented 4 months ago

@mademoiselle-chantal you can remove that code and add yours.

mademoiselle-chantal commented 4 months ago

Hello @Bhavyajain21. Apologies for taking the time to give feedback about this issue. Well, I've added some code for the validation of fields mentioned in the issue. However, l am unsure if l have all the code because l can see the Login/Signup form is not styled.

mademoiselle-chantal commented 4 months ago

By the way, l am happy to add the styles if the form has no code for that.

Bhavyajain21 commented 4 months ago

@mademoiselle-chantal please go ahead and add the styles, and feel free to make any necessary changes which you feel are important