Open Bhupesh-V opened 4 years ago
Sure @Olunusib :+1: Hit me up if you need any help
@Olunusib Are you working on this ?
Hi, is this issue still open?
Hi, is this issue still open?
yes it is
I can give it a shot!
Please assign it when you can.
Hi, I implemented a way for this to work using the media_content and links keys as suggested. This works well for the general and news feeds, but those keys almost never exist for the podcasts or newsletters feeds. Should I submit a pull request for this initial solution?
Hi, I implemented a way for this to work using the media_content and links keys as suggested. This works well for the general and news feeds, but those keys almost never exist for the podcasts or newsletters feeds. Should I submit a pull request for this initial solution?
Sure. We can ignore header images for podcasts and newsletters
Hello @Bhupesh-V , I would like to work on this issue. This is my first contribution . Please assign me a file accordingly.
Is your feature request related to a problem? Please describe. It would be nice to show some header images (if the feed provides it) Something like this probably
Describe the solution you'd like For every card rendered on webapp we can show the image if it exists The
feedparser
library colllects these links for us in a single keyUsually the images will exist in either the
links
key or sometimes inmedia_content
One thing to note that the images may exist for some source & not for others, so make sure there is a fallback mechanism (if/else to say :sweat_smile: )