Bhupesh-V / tutorialdb

A search 🔎 engine for programming/dev tutorials,
MIT License
121 stars 60 forks source link

Templates need a fixin' #12

Closed Animesh-Ghosh closed 4 years ago

Animesh-Ghosh commented 4 years ago

Templates could be managed better. Need to follow DRY Principle.

Context names could be more descriptive than "object_list".

Some method-based views can be converted to class based views.

API template is hardcoded (WHY?).

Suggestions:

  1. Static pages can be rendered by class based views.
  2. If you're using template inheritance, use it throughout the site. Edit:
  3. Move the search form to the top. It's a search engine FFS.
Bhupesh-V commented 4 years ago

API template is hardcoded (WHY?).

API template is hardcoded because installing a 3rd Party package to automatically generate is kinda burdern. I have tried it. After all we can add custom text, any warnings before using the API.

Bhupesh-V commented 4 years ago

Templates could be managed better. Need to follow DRY Principle.

This will need a further time probably move it to future releases.

Context names could be more descriptive than "object_list". Ok, that had been pending , I am opening a separate issue for this, would you like to work?

Animesh-Ghosh commented 4 years ago

Why you bully me?

Bhupesh-V commented 4 years ago

:rofl:

Why you bully me?

No , I am not

Animesh-Ghosh commented 4 years ago

Created PR #16 for fixing the templates. Will create another PR for #14.