search

Bhupesh-V / tutorialdb

A search 🔎 engine for programming/dev tutorials,
MIT License
121 stars 60 forks source link

way to handle tutorial links which are PDF #27

Open Bhupesh-V opened 4 years ago

Bhupesh-V commented 4 years ago

Describe the bug Currently if a link is sumitted, the tags are generated automatically. But the taggie app is not meant to handle PDF links

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Contribute Page'
  2. Submit a tutorial which is a link to direct PDF file.
  3. See error

Expected behavior taggie should be able to handle PDF based links

vikneswaran20 commented 4 years ago

Regarding the PDF files. We can have the name of the pdf file has the title of the article and also we can parse tags from the PDF file name. Because even the browser shows the name of the PDF file as the title in the title bar.

This will fill fix in the bug of adding the PDF files. Shall I submit a merge request regarding this change?

or We have to get the details of the PDF link from the user.

Bhupesh-V commented 4 years ago

Actually that would be a good idea. The problem is how would you differentiate a PDF link from a Non-PDF link. You can submit the PR but you would have to test it separately

vikneswaran20 commented 4 years ago

I think the url ends with .pdf for the pdf files