Bhupesh-V / tutorialdb

A search 🔎 engine for programming/dev tutorials,
MIT License
121 stars 60 forks source link

Update CONTRIBUTING.md. #49

Closed Animesh-Ghosh closed 4 years ago

Animesh-Ghosh commented 4 years ago

PRs are being created without specifying what issue it is that they are solving.

Updating CONTRIBUTING.md to say that PRs may be created only if issues exist prior to it may be a possible solution.

For example, PRs #44, #45, #46 were created without any existing issue that they are supposed to solve. PRs #41, #47 were created to solve issue #41.

hstandeffer commented 4 years ago

Hi @Animesh-Ghosh, I am trying to clone the repository but get this issue when running python manage.py test:

\venv\lib\site-packages\django\contrib\staticfiles\storage.py", line 44, in path raise ImproperlyConfigured("You're using the staticfiles app " django.core.exceptions.ImproperlyConfigured: You're using the staticfiles app without having set the STATIC_ROOT setting to a filesystem path.

Have you seen this issue before?

Animesh-Ghosh commented 4 years ago

I haven't run tests myself. I'll look into it.

hstandeffer commented 4 years ago

@Animesh-Ghosh Thank you, I've tried updating the static_dirs line, but am having no luck.

Edit: I have changed the following line in settings.py which have gotten me past the initial errors: STATIC_ROOT = os.path.join(BASE_DIR, 'staticfiles')

And now I am receiving a status code error: hacktoberfest\tutorialdb\api\tests\test_views.py", line 8, in test_tutorials_page_status_code self.assertEquals(response.status_code, 200) AssertionError: 404 != 200

Hope this helps.

Animesh-Ghosh commented 4 years ago

@hstandeffer it would be better if you moved the conversation thread to its related Issue.

hstandeffer commented 4 years ago

Will do 👍

liorbentov commented 4 years ago

PR #43 solves this issue (not the contributing.md)

Animesh-Ghosh commented 4 years ago

Closing this issue for now, as #51 has been merged.