search

BiAPoL / Quantitative_Bio_Image_Analysis_with_Python_2022

This repository hosts notebooks, information and data for the Quantitative Bio-Image Analysis with Python Course 2022.
https://BiAPoL.github.io/Quantitative_Bio_Image_Analysis_with_Python_2022
Creative Commons Attribution 4.0 International
15 stars 3 forks source link

"Structure element" -> "Footprint" #31

Open haesleinhuepf opened 1 year ago

haesleinhuepf commented 1 year ago

low priority, just in case there is time: The scikit-image developers are subsequently renaming "Strutcutal element" to "Footprint". We may want to adapt that in our materials.

See also: https://github.com/scikit-image/scikit-image/pull/5445

zoccoler commented 1 year ago

Hi Robert @haesleinhuepf ,

I would say that we can swap focus and let "footprint" be the main term because we show mostly scikit-image. By the way, I like this standardization. However, I would not entirely remove "structural element" because much of the literature about morphological operations refers to this term. To my knowledge, footprint is somewhat specific to scikit-image. For example, MATLAB uses "SE" (https://www.mathworks.com/help/images/ref/imdilate.html).

haesleinhuepf commented 1 year ago

Yes, fully agreed. I also propose to keep the content about SEs minimal because it's not so relevant for our work.

haesleinhuepf commented 1 year ago

Btw SE as variable name violates good practice in Python 😉 https://peps.python.org/pep-0008/#function-and-variable-names

zoccoler commented 1 year ago

Btw SE as variable name violates good practice in Python 😉 https://peps.python.org/pep-0008/#function-and-variable-names

Totally! Luckily this one is not in Python 😆