BiAPoL / napari-crop

BSD 3-Clause "New" or "Revised" License
7 stars 4 forks source link

removed python 3.7 and opencl from github CI #32

Closed jo-mueller closed 2 years ago

jo-mueller commented 2 years ago

I think this should fix #28 but I can't know for sure until I've started a run of the github CI.

Edit: Tests are passing, switching to non-draft mode.

Fixes #28

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@391113e). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage        ?   91.59%           
=======================================
  Files           ?        4           
  Lines           ?      119           
  Branches        ?        0           
=======================================
  Hits            ?      109           
  Misses          ?       10           
  Partials        ?        0           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

zoccoler commented 2 years ago

Hi Johannes @jo-mueller ,

I like the new test scheme! Just one question: why do we need to remove tests for 3.7?

Best, Marcelo

jo-mueller commented 2 years ago

Hi @zoccoler ,

to be honest, I don't know exactly what's causing this error with 3.7. But it has been seen elsewhere and has also been dropped from tests in napari (see this issue/ PR)

zoccoler commented 2 years ago

Hi @zoccoler ,

to be honest, I don't know exactly what's causing this error with 3.7. But it has been seen elsewhere and has also been dropped from tests in napari (see this issue/ PR)

Sounds good to me then! Can you merge?

jo-mueller commented 2 years ago

I can :)