Closed BiagioFesta closed 1 year ago
Compiling ls-qpack v0.1.2 (https://github.com/BiagioFesta/ls-qpack-rs.git?branch=fix-cast#72e9410b)
error[E0412]: cannot find type `c_char` in this scope
--> /home/mozgiii/.cargo/git/checkouts/ls-qpack-rs-8c1ccf7403e7ee19/72e9410/ls-qpack/src/decoder.rs:375:73
|
375 | this.header.buf = this.decoding_buffer.as_mut_ptr() as *mut c_char;
| ^^^^^^
|
help: a builtin type with a similar name exists
|
375 | this.header.buf = this.decoding_buffer.as_mut_ptr() as *mut char;
| ~~~~
help: consider importing one of these items
|
277 + use core::ffi::c_char;
|
277 + use crate::decoder::c_char;
|
277 + use libc::c_char;
|
277 + use std::ffi::c_char;
|
and 1 other candidate
For more information about this error, try `rustc --explain E0412`.
error: could not compile `ls-qpack` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
Consider adding Github Actions for CI at the very least they'll show when the code doesn't compile.
Consider adding Github Actions for CI at the very least they'll show when the code doesn't compile.
Yeah, it's in the TODO: https://github.com/BiagioFesta/ls-qpack-rs/issues/7
The code compiles now; need to test the actual runtime though, stay tuned.
I've been able to try this patch with wtransport on multiple arm machines (Raspberry and Ampere servers on Oracle cloud) and this seems to be working super well !
Perfect thanks!
Fixes: https://github.com/BiagioFesta/ls-qpack-rs/issues/5