search

BiagioFesta / wtransport

Async-friendly WebTransport implementation in Rust
Apache License 2.0
467 stars 31 forks source link

Fix #182: Convert error codes before passing them to QUIC #211

Open barafael opened 2 months ago

BiagioFesta commented 2 months ago

Thank you for taking care of this!

Is the reverse map necessary when receiving the code from stream's peer?

barafael commented 2 months ago

I have no idea! Sounds like yes it is?

MOZGIII commented 2 months ago

I have no idea! Sounds like yes it is?

It definitely is

MOZGIII commented 2 months ago

Check my implementation at https://github.com/MOZGIII/xwt/blob/ffc8b2cc135acaf7f5229a01775e3da92a22684e/crates/xwt-wtransport/src/lib.rs#L284-L323

Might be relevant for https://github.com/BiagioFesta/wtransport/pull/211#discussion_r1742406771

finnbear commented 2 months ago

Might be relevant for #211 (comment)

Can confirm; you use the conversion for application error/close codes, which is correct. This conversion could be moved into wtransport.

MOZGIII commented 2 months ago

Let's do it! I'm busy with building the reset support Web part of the xwt now, but feel free to port my code from that PR to wtransport