Closed skojaku closed 1 year ago
I put embedding and edge weighting in one function only to ensure the application of the correct weight formula (i.e., a distance-like or a proximity-like measure) for each embedding. But if you want to create a new script for iterative embedding where you give fixed choices for embedding-weight formula pairs, that's totally fine for me.
Done. See my PR @BianKov
Here is the readme. https://github.com/BianKov/iterEmb/tree/change-modularization
In the current implementation, an embedding function performs graph embedding, followed by edge weighting. I think it is better to separate the two for clarity, code reuse, and easy maintenance. My proposal is the following:
Simply put, I propose to split the script into three modules, "embedding.py", "edge_weighting.py", and "iterative_embedding.py", each of which contains the functions that the filename implies.