Kanban board for recipe-app

chimwemwe007 commented 6 months ago

In this issue the following were completed.

Create kanban board for the recipe app
assign tasks to each group member

Team Composition

there are three group members in this project

@BiancaMe
@chimwemwe007
@vikas924

link to Kanban board: https://github.com/users/BiancaMe/projects/4

Ibizugbe commented 6 months ago

Hi @chimwemwe007 @BiancaMe @vikas924 👋🏼👋🏼👋🏼,

request change

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights✅✅✅✅

[x] Link to project has been provided👍🏼.
[x] Currently, points are fairly distributed👍🏼.
[x] Tasks are properly assigned👍🏼.
[x] The required columns are in the kanban board👍🏼.

Required Changes ♻️

[ ] Kindly ensure you add a description for each card as this is a requirement in this milestone👍🏼. Currently, your unit test cards don't have any descriptions. please try to ensure all cards have a description👍🏼.
[ ] Some of the requirements are still not taken into account in the Kanban board😉. Kindly ensure all the requirements of the project that concern your group are captured in the Kanban board👍🏼. Currently, you have captured the n+1 requirement and the recipe details requirement for a group with 3 members👍🏼. Lastly, remember to ensure the points are fairly distributed when you take these changes into account.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

danmainah commented 6 months ago

Hi @chimwemwe007 , @BiancaMe and @vikas924 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉

Highlights

✔️ Implemented the changes requested to add missing tasks and ensure all tasks have a description

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

BiancaMe / recipe-app