search

BiancoRoyal / node-red-contrib-bacnet

maintained by PLUS for Node-RED - https://plus4nodered.com
https://www.npmjs.com/package/node-red-contrib-bacnet
MIT License
24 stars 16 forks source link

BACnet write priority settings missing #15

Closed Ekristoffe closed 2 years ago

Ekristoffe commented 4 years ago

Hello, I was playing with this node and saw there is no option to set the priority yet. Do you ave any plan to enable it in the future or could I make the modification and do a Pull request ? Thanks.

Ps I am just playing with a rpi as slave (modbus, BACnet, mqtt, ...) and a windows pc (node-red) at home.

biancode commented 4 years ago

v0.2.3 released - @Ekristoffe please test it

Ekristoffe commented 4 years ago

thanks

Ekristoffe commented 4 years ago

The change work fine but I think it could be better. I will made some minor change: Put in the textbox the default value grayed. Change the default value to 16 (Lowest priority available) Is there other changes needed ?

biancode commented 4 years ago

v0.2.4 released - @Ekristoffe please test it

biancode commented 4 years ago

@Ekristoffe you're right codacy lost the eslint settings again ... I'll fix that in the next few days to get it checked with single quotes, no semis and standardjs linting ;)

Ekristoffe commented 4 years ago

@biancode I saw on the codacy pages we can include a ESLint configuration file in the repository root to have those settings set.

Ps v0.2.4 work fine thanks.

biancode commented 4 years ago

eslint is now added in develop branch, but I did not test or check it for now ...

biancode commented 4 years ago

image

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.