search

BiancoRoyal / node-red-contrib-bacnet

maintained by PLUS for Node-RED - https://plus4nodered.com
https://www.npmjs.com/package/node-red-contrib-bacnet
MIT License
25 stars 16 forks source link

Code review + Improvement #17

Closed Ekristoffe closed 4 years ago

Ekristoffe commented 4 years ago

Add ; at the end of the line. Change ' into " for strings. Check the settings in the html file. Set the default priority to 16.

biancode commented 4 years ago

@Ekristoffe I cannot accept this PR because it violates the CONTRIBUTION rules and makes format changes that are undesirable.

biancode commented 4 years ago

We use standard.js - please use the npm scripts to test and lint the code! ;)

biancode commented 4 years ago

see CONTRIBUTING.md

Ekristoffe commented 4 years ago

funny that you use standard.js (single quote and other) but the automatic code review give error on it. Maybe configure the automatic code review ? I will roll it back to the standard.js system

Ekristoffe commented 4 years ago

I will make a cleaner one, in the mean time I close this one.