BiancoRoyal / node-red-contrib-iiot-opcua

deprecated - very new developed by PLUS for Node-RED - https://plus4nodered.com

https://www.npmjs.com/package/node-red-contrib-iiot-opcua

BSD 3-Clause "New" or "Revised" License

34 stars 8 forks source link

Feature/163 test e2e for browse node #191

Closed ghost closed 1 year ago

ghost commented 2 years ago

Which issues are addressed by this Pull Request?

163

What does this Pull Request change? This pull request improves the type safety of the if statement diagnosed as the issue in #163. It also switches a test case of the buildNewVariant function to test a double value of 0.0 and adds a test case to test a boolean value of false;

Does this Pull Request introduce any potentially breaking changes?

github-actions[bot] commented 2 years ago

Greet Contributors Bot
Thank you for taking your time and effort for your contribution, we truly value it. :tada:

The amazing contributor in this pull request is @dtq-three

biancode commented 1 year ago

Hi @dtq-three, thank you for the PR, could you please test with values again and not with 0,00 - Zero is a default and we do not see anymore that a value like 22.2 before works as expected. Or was there a reason to set it to zero?

ghost commented 1 year ago

looks like the PR was opened prematurely, since this was not taken into consideration. sorry about that. closing again