jewendt commented 5 years ago

Setup a simple inject, read, filter request with one tag however the filter returns null with version 3.4.1. Reinstalled 2.7.1 and it works perfectly. I am running 19.4 version of node red utilizing Node version 10.13.0 on Windows 10.

biancode commented 5 years ago

Some example to reproduce that?

_{Sent with GitHawk}

jewendt commented 5 years ago

Sure. This flow works fine in 2.7.1. I thought I was losing my mind. About as basic as you can get unless I am missing something.

[{"id":"7745920a.b8d67c","type":"tab","label":"Flow 5","disabled":false,"info":""},{"id":"a0845b5.42933a8","type":"OPCUA-IIoT-Inject","z":"7745920a.b8d67c","injectType":"inject","payload":"","payloadType":"date","topic":"","repeat":"","crontab":"","once":false,"startDelay":"","name":"","addressSpaceItems":[{"name":"","nodeId":"ns=2;s=Channel5.Device1.Global.LINE_10_BARCODE.DATA","datatypeName":""}],"x":124.10000610351562,"y":99.80000305175781,"wires":[["1c6124b.348acdb"]]},{"id":"1c6124b.348acdb","type":"OPCUA-IIoT-Read","z":"7745920a.b8d67c","attributeId":0,"maxAge":1,"depth":1,"connector":"1a2d29f3.31d5c6","name":"","justValue":true,"showStatusActivities":false,"showErrors":false,"parseStrings":false,"x":193.10001373291016,"y":25.800004959106445,"wires":[["c708e125.042e1","627656c9.dc7758"]]},{"id":"c708e125.042e1","type":"OPCUA-IIoT-Result-Filter","z":"7745920a.b8d67c","nodeId":"ns=2;s=Channel5.Device1.Global.LINE_10_BARCODE.DATA","datatype":"","fixedValue":false,"fixPoint":2,"withPrecision":false,"precision":2,"entry":1,"justValue":true,"withValueCheck":false,"minvalue":"","maxvalue":"","defaultvalue":"","topic":"","name":"","showErrors":false,"x":564.1000900268555,"y":51.80000591278076,"wires":[["b7311ce3.fbd3e"]]},{"id":"627656c9.dc7758","type":"debug","z":"7745920a.b8d67c","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":548.1000366210938,"y":208.39999389648438,"wires":[]},{"id":"b7311ce3.fbd3e","type":"debug","z":"7745920a.b8d67c","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":577.1000366210938,"y":122.40000915527344,"wires":[]},{"id":"1a2d29f3.31d5c6","type":"OPCUA-IIoT-Connector","z":"","discoveryUrl":"","endpoint":"opc.tcp://Cgshopopsdev5.andersencorp.com:49320","keepSessionAlive":true,"loginEnabled":false,"securityPolicy":"None","securityMode":"NONE","name":"LOCAL SERVER","showErrors":false,"publicCertificateFile":"","privateKeyFile":"","defaultSecureTokenLifetime":"","endpointMustExist":true,"autoSelectRightEndpoint":true,"strategyMaxRetry":"","strategyInitialDelay":"","strategyMaxDelay":"","strategyRandomisationFactor":"","requestedSessionTimeout":""}]

jewendt commented 5 years ago

I see you tagged it as a bug. Were you able to recreate the problem or do you need more details?

biancode commented 5 years ago

Yes, it is a problem with the Read node output. It was out of my scope because I do just use them with the Listener node. I write some tests and release a fix for that soon.

jewendt commented 5 years ago

Thanks. I was surprised that this wasn't caught before now. so I was thinking I was using the nodes wrong. Just for my education, can you explain the difference in intent between utilizing the listening versus read node?

biancode commented 5 years ago

Thanks. I was surprised that this wasn't caught before now. so I was thinking I was using the nodes wrong. Just for my education, can you explain the difference in intent between utilizing the listening versus read node?

Watch this

jewendt commented 5 years ago

biancode I tested this again and the filter now isn't returning anything at all. Before it was returning null now, it is not doing anything. Should I open up another issue? Here is my test case

[{"id":"8eef632e.f4387","type":"tab","label":"Flow 9","disabled":false,"info":""},{"id":"6eb3a8e0.2efa88","type":"OPCUA-IIoT-Read","z":"8eef632e.f4387","attributeId":0,"maxAge":1,"depth":1,"connector":"9313e652.2ea988","name":"","justValue":true,"showStatusActivities":true,"showErrors":true,"parseStrings":false,"historyDays":1,"x":425.0000305175781,"y":76,"wires":[["b76cc4e2.97b278","d7b2a39b.c14a8"]]},{"id":"b12b549a.250b28","type":"OPCUA-IIoT-Inject","z":"8eef632e.f4387","injectType":"read","payload":"","payloadType":"date","topic":"","repeat":"","crontab":"","once":false,"startDelay":"","name":"","addressSpaceItems":[{"name":"","nodeId":" ns=2;s=Channel5.Device1.Global.LINE_10_BARCODE.DATA","datatypeName":""},{"name":"","nodeId":" ns=2;s=Channel5.Device1.Global.LINE_10_BARCODE_COUNT.DATA","datatypeName":""}],"x":203,"y":86,"wires":[["6eb3a8e0.2efa88"]]},{"id":"b76cc4e2.97b278","type":"OPCUA-IIoT-Result-Filter","z":"8eef632e.f4387","nodeId":"ns=2;s=Channel5.Device1.Global.LINE_10_BARCODE_COUNT.DATA","datatype":"ns=0;i=12","fixedValue":false,"fixPoint":2,"withPrecision":false,"precision":2,"entry":"2","justValue":true,"withValueCheck":false,"minvalue":"","maxvalue":"","defaultvalue":"","topic":"","name":"","showErrors":true,"x":418.00006103515625,"y":211.8000030517578,"wires":[["73c8c4ad.07b97c"]]},{"id":"d7b2a39b.c14a8","type":"debug","z":"8eef632e.f4387","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":625.0000305175781,"y":70.5999984741211,"wires":[]},{"id":"73c8c4ad.07b97c","type":"debug","z":"8eef632e.f4387","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":815.0001220703125,"y":116.60000419616699,"wires":[]},{"id":"9313e652.2ea988","type":"OPCUA-IIoT-Connector","z":"","discoveryUrl":"","endpoint":"opc.tcp://Cgshopopsdev5.andersencorp.com:49320","keepSessionAlive":true,"loginEnabled":false,"securityPolicy":"None","securityMode":"NONE","name":"LOCAL SERVER","showErrors":false,"publicCertificateFile":"","privateKeyFile":"","defaultSecureTokenLifetime":"","endpointMustExist":false,"autoSelectRightEndpoint":false,"strategyMaxRetry":"","strategyInitialDelay":"","strategyMaxDelay":"","strategyRandomisationFactor":"","requestedSessionTimeout":"","maxBadSessionRequests":10}]

biancode commented 5 years ago

Please, try to remove the data type on reading all instead of value!

biancode commented 5 years ago

If you set a data type use the selection, please!

biancode commented 5 years ago

If you just want to filter the name, please use the filter inside the response node!

jewendt commented 5 years ago

Ok, yes I have it working. But help me understand if there is any easy way to just read a simple value??? I am trying to develop a course on this and am just looking for the simplest way. On those lines what is the difference between the IIOT-OPCUA and just OPCUA nodes? Is one replacing the other? Looks like you are involved it both.

biancode commented 5 years ago

I'm working on that to fix all issues I've found ;)

biancode commented 5 years ago

I do a refactoring of the whole project at the moment and it will get more tests in the future.

jewendt commented 5 years ago

Ok, so to try and be "future proof" I should be using the IIOT-OPCUA one? BTW...thanks for all your hard work on this!

biancode commented 5 years ago

yes, please, use the IIoT OPC UA package and give me your feedback! It should become stable again in the next few days.

biancode commented 5 years ago

fixed with v3.6.+

biancode commented 5 years ago

see the new result-filter flow example in node-red via menu -> import -> examples -> iiot opcua -> client -> result filter

biancode commented 5 years ago

biancode commented 5 years ago

that needs to import the server-demo example too

BiancoRoyal / node-red-contrib-iiot-opcua

Result filter works in version 2.7.1 but not in 3.4.1 #70

biancode I tested this again and the filter now isn't returning anything at all. Before it was returning null now, it is not doing anything. Should I open up another issue? Here is my test case