search

BibleGet-I-O / bibleget-wordpress

Plugin for WordPress that let's you insert Bible quotes into your posts or pages from a variety of Bible versions in different languages. This is a mirror of the SVN repo where the plugin gets published to the WordPress plugins store. Kudos to @kas-catholic for helping import the repo from SVN.
https://www.bibleget.io
Apache License 2.0
0 stars 2 forks source link

in the newer Gutenberg releases, the `label` seems to force positioned to the side? #10

Closed JohnRDOrazio closed 3 years ago

JohnRDOrazio commented 3 years ago

I haven't yet encountered this problem in the current WordPress releases. However when testing the latest build of the Gutenberg plugin (which will eventually be incorporated into the WordPress core), I noticed the label for the SelectControl component was positioned on the left side of the SelectControl, effectively giving the component even less space than it already had. I see they added a new option labelPosition, which theoretically defaults to top so should not have been an issue. However it was an issue, and even when trying to explicitly set labelPosition to top, it still rendered on the side. Perhaps the implementation is still being written, in any case I opened an issue on the Gutenberg repo to address this: https://github.com/WordPress/gutenberg/issues/29447

Hopefully it will be looked into and fixed. With a few tests in the Chrome developer tools I was able to fix this by setting the flex-direction to column instead of row. If it doesn't get fixed before Gutenberg is again incorporated into WordPress core, we will have to address the issue by forcing the styles in the BibleGet plugin.

JohnRDOrazio commented 3 years ago

This seems to be a non issue actually. Something might have gone haywire in my local repo after the main branch was renamed to trunk. I have completely removed my local copy of my fork, renamed the main branch of my fork to trunk, recloned my fork, and resynched to upstream Gutenberg repo. Now in my local wp-env with WP 5.8 and Gutenberg 10.1.0, this issue is non existent. So I'm going to go ahead and close this.