search

BibleGet-I-O / bibleget-wordpress

Plugin for WordPress that let's you insert Bible quotes into your posts or pages from a variety of Bible versions in different languages. This is a mirror of the SVN repo where the plugin gets published to the WordPress plugins store. Kudos to @kas-catholic for helping import the repo from SVN.
https://www.bibleget.io
Apache License 2.0
0 stars 2 forks source link

unexpected lexical declaration in case block #16

Closed JohnRDOrazio closed 7 months ago

JohnRDOrazio commented 7 months ago

After the recent updates to the codebase which modernized the javascript, using let and const and arrow functions, I am now seeing a couple of these warnings from codefactor:

unexpected lexical declaration in case block Found in js\admin.js:337 337

const maxedOutUpdateThisRun = maxUpdatePerRun * thisRun;

Found in js\admin.js:336 336

const maxUpdatePerRun = 100 / postdata.numRuns;
JohnRDOrazio commented 7 months ago

should be fixed in commit 3485063 . Same commit also fixed another issue with assignment which was actually using a comparison operator.