BibleGet-I-O / endpoint

API endpoints for the BibleGet I/O project
https://query.bibleget.io
Apache License 2.0
9 stars 1 forks source link

NABRE Books with errors #30

Closed JohnRDOrazio closed 2 years ago

JohnRDOrazio commented 2 years ago

tobit 5 Has  22 verses for NABRE the end point returns an error for anything past 5:1

tobit 6 Verse 1 was a part of Chapter 5 in the NABRE version It does not show up when queried tobit 6:1

Job 9 Has 35 verses and returns an error on verses past 10

daniel 10 Has 21 verses  showed an error on verse 2 or greater.

JohnRDOrazio commented 2 years ago

Info received from Bob Welch

JohnRDOrazio commented 2 years ago

https://bible.usccb.org/bible/tobit/5

Shows verse 1 of chapter 6 at the end of chapter 5. Is this a mistake?

JohnRDOrazio commented 2 years ago

I see the problem with Job 9: since the USCCB text has added verse 10:1 at the end of chapter 9, 10:1 was being treated as the limit for chapter 9. Which means that any verse beyond verse 10 was being seen as out of bounds. I have now corrected the verse limit in the database with 35, and a request for verses up to and including 35 will also return 10:1 as the last verse. To be seen if this is intended or is a mistake on the USCCB website...

https://bible.usccb.org/bible/job/9

JohnRDOrazio commented 2 years ago

There is a footnote for Job 10:

  • [10:1] I loathe my life: these words complete the thought of 9:35.

So 10:1a is purposefully treated as the last verse of Job 9. Should verse 10:1 be returned in a request for Job 10:1?

JohnRDOrazio commented 2 years ago

Because of this situation, we were missing what NABRE considers as Job 10:1, i.e.

I will give myself up to complaint; I will speak from the bitterness of my soul.

This has now been corrected, this verselet has been added to the database as Job 10:1. And Job 10:1a should show in a request for Job 9 up to verse 35. I think this is an acceptable compromise to try to respect the NABRE numbering.

JohnRDOrazio commented 2 years ago

As regards Tobit 6:1, I'm pretty sure the NABRE included it at the end of chapter 5 because it's considered the end of a logical unit in the narrative. However, for the sake of quoting by chapter and verse, we need to be able to quote it as Tobit 6:1, so I have now added it to the database between Tobit 5:22 and Tobit 6:2.

JohnRDOrazio commented 2 years ago

As for the book of Daniel, looking at the source text of the NABRE, I see that Daniel 11:1 was included at the end of Daniel 10, after verse 21:

<p><v id="34010015"><bcv>15</bcv>While he was speaking thus to me, I fell forward and kept silent.</v> <v id="34010016"><bcv>16</bcv>Then something like a hand touched my lips; I opened my mouth and said to the one standing before me, &#8220;My lord, I was seized with pangs at the vision and I was powerless.</v> <v id="34010017"><bcv>17</bcv>How can my lord&#8217;s servant speak with you, my lord? For now no strength or even breath is left in me.&#8221;</v> <v id="34010018"><bcv>18</bcv>The one who looked like a man touched me again and strengthened me, saying,</v> <v id="34010019"><bcv>19</bcv>&#8220;Do not fear, beloved. Peace! Take courage and be strong.&#8221; When he spoke to me, I grew strong and said, &#8220;Speak, my lord, for you have strengthened me.&#8221;</v> <v id="34010020"><bcv>20</bcv>&#8220;Do you know,&#8221; he asked, &#8220;why I have come to you? Soon I must fight the prince of Persia again. When I leave, the prince of Greece will come;</v> <v id="34010021"><bcv>21</bcv>but I shall tell you what is written in the book of truth.<fnref id="34010021-1">*</fnref> No one supports me against these except Michael,<enref id="34010021-b">b</enref> your prince,</v> <v id="34011001"><bcv>1</bcv>and in the first year of Darius the Mede I stood to strengthen him and be his refuge.</v></p>

And yet, on the USCCB website, Daniel 11:1 is still showing as the first verse of Daniel 11:

https://bible.usccb.org/bible/daniel/10 https://bible.usccb.org/bible/daniel/11

In the database, I have all verses of Daniel 10, up to verse 21. But I am missing Daniel 11:1, will need to be added.

JohnRDOrazio commented 2 years ago

And for whatever reason, the index table for Daniel had verse 1 as the limit on chapter 10. This has now been fixed, with the verse limit at 21.