As can be seen from in scripture-editors codesandbox the <h2 class="CommentPlugin_CommentsPanel_Heading">Comments</h2> overflows the comment container.
In Platform.Bible this causes a "right hand" overflow, that produces a vertical scroll bar:
Which can also be seen in the codesandbox:
It is fixed by removing width: 100% from .CommentPlugin_CommentsPanel_Heading
[x] issue 2: header text is clipped
See pictures below.
.CommentPlugin_CommentsPanel_Heading should get
text-overflow: ellipsis; /* clip the header text */
padding: 16px /* have symetric padding in a 2^n grid value */
/* remove height: 34px; */
/* you may or may not want to add line-height: 16px, as the font itself seems to create some additional whitespace */
Now also remove the top: 45px from .CommentPlugin_CommentsPanel_List
Before:
After:
[x] issue 3: placeholder text "No Comments" is not visible
position: absolute should be removed from .CommentPlugin_CommentsPanel_Heading
with position: absolute
when removing position: absolute
Removing it seems not to have a negative impact on the comment list
I identified 3 issues with the comment sidebar:
As can be seen from in scripture-editors codesandbox the![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/af2e006c-08b8-42d4-8df0-beb67bc4613b)
<h2 class="CommentPlugin_CommentsPanel_Heading">Comments</h2>
overflows the comment container.In Platform.Bible this causes a "right hand" overflow, that produces a vertical scroll bar:![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/9793e445-c868-4229-840d-1ff0abc605df)
Which can also be seen in the codesandbox:![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/417c205d-48c7-43b9-8dd4-b484ac704660)
It is fixed by removing
width: 100%
from.CommentPlugin_CommentsPanel_Heading
See pictures below.
.CommentPlugin_CommentsPanel_Heading
should getNow also remove the
top: 45px
from.CommentPlugin_CommentsPanel_List
Before:![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/14005fb8-d302-4baf-b453-62abe87be9cc)
After:
position: absolute
should be removed from.CommentPlugin_CommentsPanel_Heading
with![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/f56a0a9c-60ad-4648-a1f0-df5dc4c86b82)
position: absolute
when removing![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/f889b027-b7c0-4ac8-b68b-028cb89bd928)
position: absolute
Removing it seems not to have a negative impact on the comment list![grafik](https://github.com/BiblioNexus-Foundation/scripture-editors/assets/141921979/7046fde9-a2bd-4107-b206-3ec10ba6e20c)