search

BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
1 stars 1 forks source link

Support right-to-left layouts (not only the text direction inside the editor) #125

Open Sebastian-ubs opened 2 months ago

Sebastian-ubs commented 2 months ago

I recognized that in the editor code some things are layouted with "left" and "right" properties, (e.g. padding-left when there is padding-right with similar value used).

We should try to avoid these, to be able to support right-to-left layouts easily. In a right-to-left layout e.g. a sidebar would appear at the other side than in a left-to-right layout. Maybe the following articles could be helpful: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values/Basic_concepts_of_logical_properties_and_values

I don't have many more details about this. I came across it when setting up components and layouts for Platform.Bible, where we 1) try to omit Tailwind classes with directional values and replace them with logical ones 2) have created a small vite test app with a button that toggles text direction to be able to easily test components on their RTL awareness. Maybe something similar could be built into the scripture-editor codesandbox

grafik

irahopkinson commented 2 months ago

@Sebastian-ubs thanks for this. The editor is not claiming RTL support yet. RTL support is on the roadmap for this quarter so this issue will be useful for moving that forward this quarter.