BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
3 stars 1 forks source link

Platform: Adding comments deletes text or breaks the editor #129

Closed Sebastian-ubs closed 4 months ago

Sebastian-ubs commented 4 months ago

When adding a comment to a text part with style type "no Style" it breaks the editor (looks like the comment can be created, but breaks on re-rendering). When reopening the editor it is blanked out - and so the user is unable to recover from this! grafik grafik

Maybe related to some strange text that also gets added when adding text to other passages: Screenshot 2024-07-03 183517 Screenshot 2024-07-03 183532

Deleting that comment does not delete the strange text. Manually deleting the text leaves the editor in some crazy state. Screenshot 2024-07-03 183612

looking into the .sfm file shows

\v 2 You \zmsc-s |sid="xcyur" \know \zmsc-e |eid="xcyur" \, all da stuff da angel guys wen tell befo time was da trut, an was from God. If had peopo dat wen broke da Rules From God an neva lissen, God wen do da right ting wen he punish um fo da Rules dey wen broke.

root cause for https://github.com/paranext/paranext-core/issues/980

irahopkinson commented 4 months ago

@Sebastian-ubs I see this issue is when you are using the editor in P.B (Platform.Bible). Before you add comments to any PT project in P.B you will need to add a custom.sty file to the root of that PT project folder. You can copy that file from https://github.com/paranext/paranext-core/blob/main/assets-excluded/custom.sty We haven't yet decided that we will mark comments this way in the Scripture text but until we decide and implement otherwise you need this file in any PT project you want to comment on.

Sebastian-ubs commented 4 months ago

confirmed