search

BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
1 stars 1 forks source link

124 improve comment sidebar styling #130

Closed irahopkinson closed 2 months ago

irahopkinson commented 2 months ago
nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a7f705fe71ae5424f717098a28428c0ab862d579. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx run-many -t build`](https://cloud.nx.app/runs/m1ggxg0KOZ?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t test`](https://cloud.nx.app/runs/xs5hzHgMop?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t typecheck`](https://cloud.nx.app/runs/XrS7yjGxML?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t lint`](https://cloud.nx.app/runs/nIjCm86aax?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

irahopkinson commented 2 months ago

@Sebastian-ubs thanks for detailing this in #124. Would appreciate your code review. You can test this in CodeSandbox.

irahopkinson commented 2 months ago

It worked when I tested it there. Did you click on the link I provide in my last post as that checks out the branch these changes are made on (since the code isn't merged to main yet)?

irahopkinson commented 2 months ago

@Sebastian-ubs ah, that link won't work for you because there is a pending invite to the CodeSandbox workspace for you (it was sent quite some time ago so trawl your inbox). You need to accept that and be logged in to see the latest changes. You have probably been missing all kinds of the latest changes.

Sebastian-ubs commented 1 month ago

Thank you Ira, I have clicke the link. Will see if it changes anything for new branches. At least I can see those changes on the codesandbox master now.