irahopkinson commented 1 month ago

Relies on fix in Lexical v0.17.0
no context menu for ImmutableChapterNode
ensure ImmutableChapterNode is not inline for c/v
also ChapterNode no longer appends a text child (since this previously caused a stack overflow for BookNode)
also ensure Scribe ScriptureReferencePlugin will unregister its command
also move functions and various clean-ups
also make unit tests run silently

codesandbox[bot] commented 1 month ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bb02add8414a1ace82d758e50c4aafb1e52ce406. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

- [`nx run-many -t build`](https://cloud.nx.app/runs/lBtngUgRii?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t test`](https://cloud.nx.app/runs/xjKhfdax7w?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t typecheck`](https://cloud.nx.app/runs/ZmGPh2ZS0B?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t lint`](https://cloud.nx.app/runs/LSBL5JZoiF?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

BiblioNexus-Foundation / scripture-editors

fix #133 #142

Review or Edit in CodeSandbox

☁️ Nx Cloud Report