search

BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
3 stars 1 forks source link

Fix markers menu #172

Closed abelpz closed 1 month ago

abelpz commented 1 month ago

Adds marker assistance to perf-react:

Contextualized means that depending on the cursor location in the document, some usfm markers are suggested in the menus and some are ignored.

codesandbox[bot] commented 1 month ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview
nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 110dce28f04be54a7454e06b6c99ae10034669f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx run-many -t build`](https://cloud.nx.app/runs/VylzpgReVm?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t test`](https://cloud.nx.app/runs/ELew2MpTIc?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t typecheck`](https://cloud.nx.app/runs/uW4CfM0lop?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t lint`](https://cloud.nx.app/runs/R0Hr7BNxyU?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

abelpz commented 1 month ago

I've only reviewed half the files so far. This quite a large code review and I'm struggling to see the wood for the trees. Could you walk me through this feature change or make a small demo video?

Sure! Here are some videos:

Feature demo: https://drive.google.com/file/d/10wPUnhs_EjSlODjwmG6q_qSTBIRAXD4h/view Code explanation: https://drive.google.com/file/d/1Ka7ikjc7EKAeLSmWQNioqmAM-LDMMgDt/view

irahopkinson commented 1 month ago

Thanks @abelpz. That confirmed what I thought I should be seeing. However, when I run this branch (nx dev perf-react) and type "\" I only see the backslash but no menu pops up for me. I did an pnpm i. I don't think I need to run the generator as you have checked in the files at \packages\shared\utils\usfm\. Any thoughts on what might not be working for me? BTW I'm running in Win11. I also have WSL2 so I could try it on Linux if you think that might help.

netlify[bot] commented 1 month ago

Deploy Preview for biblical-editor ready!

Name Link
Latest commit 110dce28f04be54a7454e06b6c99ae10034669f6
Latest deploy log https://app.netlify.com/sites/biblical-editor/deploys/66f624304485ed0008544685
Deploy Preview https://deploy-preview-172--biblical-editor.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

abelpz commented 1 month ago

Thanks @abelpz. That confirmed what I thought I should be seeing. However, when I run this branch (nx dev perf-react) and type "\" I only see the backslash but no menu pops up for me. I did an pnpm i. I don't think I need to run the generator as you have checked in the files at \packages\shared\utils\usfm\. Any thoughts on what might not be working for me? BTW I'm running in Win11. I also have WSL2 so I could try it on Linux if you think that might help.

@irahopkinson I fixed that on another branch I'll bring it here. It doesn't work if you type the backslash directly after a character it needs to be after a space or as the first character of a paragraph. That's the bug I fixed on a separate branch.

abelpz commented 1 month ago

Thanks for taking the time to review this PR @irahopkinson, I am learning a lot from your comments. And learning to be more conscious about what I leave behind there in the code too. 👍